Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license a tests in PyPi releases #22

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Conversation

onovy
Copy link
Contributor

@onovy onovy commented Dec 31, 2018

Both of these are important for Debian package.

Thanks.

Copy link
Member

@mmerickel mmerickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are now including * from a folder containing python code, I'd push for adding some global-exclude directives for cached files.

https://github.com/Pylons/pyramid/blob/d00d868881e2f5260170b48deacc57a8c21f1392/MANIFEST.in#L15-L16

@digitalresistor
Copy link
Member

digitalresistor commented Jan 2, 2019

We should use graft vs include too, especially if we are passing * as to the files to be included.

@onovy
Copy link
Contributor Author

onovy commented Jan 2, 2019

done

@digitalresistor
Copy link
Member

This looks good to me, lets make sure that @mmerickel is also happy with it :-)

@cdent
Copy link
Contributor

cdent commented Jan 2, 2019

looks fine to me, too

@mmerickel
Copy link
Member

Thanks @onovy!

@cdent
Copy link
Contributor

cdent commented Jan 7, 2019

@onovy are you packaging pastedeploy and thus need a new release with this included to make things good, or can/should we wait for the next bug fix or feature to do a release? Either is fine, doing a release is no big deal.

@onovy
Copy link
Contributor Author

onovy commented Jan 7, 2019

hi,

it's fine for me to wait for next release (bugfix/feature). I workarounded it this way:

https://salsa.debian.org/python-team/modules/pastedeploy/commit/895dc7734a42d06a2f9292dc8cdb94644e6c8d44

@cdent cdent merged commit 596ec68 into Pylons:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants