Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set custom request properties in pyramid.scripting (issue #520) #538

Closed
wants to merge 1 commit into from
Closed

Set custom request properties in pyramid.scripting (issue #520) #538

wants to merge 1 commit into from

Conversation

dairiki
Copy link
Contributor

@dairiki dairiki commented Apr 17, 2012

Bump: This is the commit referenced in #520 rebased onto the current head (and formulated as a pull request to garner more attention.)

@mmerickel
Copy link
Member

crap I actually tried to find this issue when I was toying with the request properties

I will try to think about it tonight

@mmerickel
Copy link
Member

We added support for config.set_request_method which handles methods as well as properties. Looking at this diff I do not think it will work for methods in its current form. Shouldn't be a tough fix though.

@dairiki
Copy link
Contributor Author

dairiki commented Apr 20, 2012

Okay, feeling stupid here. I’m not able to find anything about config.set_request_method. (I’ve just grepped the master branch.) Can you give me a pointer?

@mmerickel
Copy link
Member

Apologies, I didn't realize I hadn't merged it yet. It will be going in soon though.

mmerickel/pyramid@master...feature.instance-properties

@dairiki
Copy link
Contributor Author

dairiki commented Apr 20, 2012

Aha. Well, let me know if/when you want me to do anything on this.

(If it's allowable to use .config.factories._set_request_extensions() from .scripting._make_request(), the adjustment is trivial.)

@mmerickel mmerickel mentioned this pull request May 4, 2012
Closed
mcdonc added a commit that referenced this pull request Sep 11, 2012
@mcdonc
- Request properties and methods added via ``config.set_request_prope…
7359873 
…rty`` or

  ``config.add_request_method`` are now available to tweens.

- Request properties and methods added via ``config.set_request_property`` or
  ``config.add_request_method`` are now available in the request object
  returned from ``pyramid.paster.bootstrap``.

Related partially to issue #520 and issue #538 and issue #596, although it doesn't actually allow us to close any of them, because we still don't issue a newrequest event when bootstrap is used.
@mmerickel
Copy link
Member

This has been fixed in 7359873 and released in 1.4a1.

@mmerickel mmerickel closed this Nov 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dairiki @mmerickel