Documentation/accept #1487
Merged
Documentation/accept #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +109,12 @@ Deprecations | |||
| Docs | |||
| ---- | |||
|
|
|||
| - Moved the documentation for ``accept`` on ``Configurator.add_view`` to no | |||
| longer be part of the decorator list. See | |||
There was a problem hiding this comment.
Good catch. Fixed! Thank you.
While accept is partially documented as a predicate, it is actually NOT a predicate in that the view machinery has all kinds of special cases for it. This also means that `not_` will not function on it correctly since it is not actually a predicate.
While this is somewhat a predicate, it really isn't for all intents and purposes because it is treated special. Make sure we document it that way.
| longer be part of the predicate list. See | ||
| https://github.com/Pylons/pyramid/issues/1391 for a bug report stating | ||
| ``not_`` was failing on ``accept``. Discussion with @mcdonc led to the | ||
| conclusion that it should not be documented as a predicate. |
There was a problem hiding this comment.
Can you reference this PR pretty please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to: #1391 and #1481 this is a documentation change that moves accept from a predicate to a non-predicate.
This then explicitly documents that
not_will not work with it since it is not technically a predicate.