Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Circus as a pserve --daemon replacement. Refs #1554, #1641 #1907

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Mention Circus as a pserve --daemon replacement. Refs #1554, #1641 #1907

merged 1 commit into from
Oct 15, 2015

Conversation

mnaberez
Copy link
Contributor

@mnaberez mnaberez commented Oct 1, 2015

Circus is a newer Python-based process manager similar to Supervisor. It is worth mentioning as a pserve --daemon replacement.

@digitalresistor
Copy link
Member

👎 The only reason supervisord is listed is because it was originally built by @mcdonc. I don't think it is a good idea to keep adding to that list, what about nosh, deamontools, s6, and others? Should all of those be mentioned?

systemd and upstart are from Red Hat and Ubuntu respectively, two of the largest Linux distributions, and supervisor was mentioned as an alternative (heavily used too).

@mnaberez
Copy link
Contributor Author

mnaberez commented Oct 2, 2015

The only reason supervisord is listed is because it was originally built by @mcdonc. I don't think it is a good idea to keep adding to that list, what about nosh, deamontools, s6, and others? Should all of those be mentioned?

I didn't realize that's the only reason. I figured it was listed because it's Python-based and popular with Python users. Circus is newer but also Python-based and popular with Python users. I don't think every tool should be listed, but I think suggesting the two major Python-based solutions would be helpful since Pyramid users probably like Python.

@mmerickel
Copy link
Member

I'm more likely to remove the suggested alternatives than to add more process managers to the list. If you feel like circus is being slighted would you prefer me to do that?

@mnaberez
Copy link
Contributor Author

mnaberez commented Oct 2, 2015

I'm more likely to remove the suggested alternatives than to add more process managers to the list. If you feel like circus is being slighted would you prefer me to do that?

I think the suggestions in the message are a good idea if pserve --daemon is deprecated. Without any suggestion, users are kind of left at a dead end when they see the deprecation ("ok, I shouldn't use --daemon, now what?"). At least it gives them some keywords as a starting point.

The listed OS-level solutions, Upstart and Systemd, are both widely used and it makes sense to mention both. The Python-based solutions Supervisor and Circus have some overlap but they're not quite the same type of tool (not designed to be "pid 1"). They're both popular with Python users and each has pros and cons. I think it would be helpful to mention both of them since Pyramid is also Python.

@digitalresistor
Copy link
Member

Define popular, until today I had never heard of Circus, and I am fairly well engrained within the Python community. Supervisor on the other hand is really popular even outside of the Python users due to it's heavy use in Docker at one point in time (not sure if that is still the case).

@cguardia
Copy link
Member

cguardia commented Oct 2, 2015

Not saying that should be the main criterion, but supervisor has almost 400,000 downloads this month on pypi, and circus around 11,000. Don't know if circus is usually installed in some other way, but it doesn't seem as they are in the same order of magnitude, popularity wise.

@mnaberez
Copy link
Contributor Author

mnaberez commented Oct 2, 2015

Define popular, until today I had never heard of Circus, and I am fairly well engrained within the Python community. Supervisor on the other hand is really popular even outside of the Python users due to it's heavy use in Docker at one point in time (not sure if that is still the case).

Circus has enough PyPI downloads and GitHub stars where I think saying it is popular shouldn't be too controversial. However, I don't think I compared its popularity to Supervisor, and that wasn't my intention. What I tried to say above is that I think there are two types of these tools, the "pid 1" solutions (Upstart, Systemd) and the Python-based solutions (Supervisor, Circus). Since the Python-based solutions are especially interesting to Python users, and there are definitely differences between them, I think it would be helpful to list the two.

@sontek
Copy link
Member

sontek commented Oct 11, 2015

I think giving people suggestions is better than removing them completely and although circus may not be as popular, I have heard of it and know companies like Mozilla are using it with great success.

Since @mnaberez is the maintainer of supervisor and hes suggesting we include circus as an alternative I'm thinking hes probably a good authority on what we should suggest here =)

mmerickel added a commit that referenced this pull request Oct 15, 2015
…lacement

Mention Circus as a pserve --daemon replacement. Refs #1554, #1641
@mmerickel mmerickel merged commit 14a28d2 into Pylons:master Oct 15, 2015
@mmerickel
Copy link
Member

Alright, thanks @mnaberez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants