Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change column Page.data to Text in wiki2 tutorial #2591

Merged
merged 1 commit into from
May 21, 2016
Merged

Change column Page.data to Text in wiki2 tutorial #2591

merged 1 commit into from
May 21, 2016

Conversation

viniciusban
Copy link
Contributor

Column data in Page class is Integer but should be Text in wiki2 tutorial.

@mmerickel
Copy link
Member

How'd that get through? Anyway, nice catch. LGTM

@viniciusban
Copy link
Contributor Author

Because of this: http://www.sqlite.org/different.html

tl;dr: almost everything is stored as string. See the "Manifest typing" section.

@mmerickel
Copy link
Member

I'm aware of sqlite's typing issues but usually SQLAlchemy will complain somewhere along the lines. In this case it looks like it just shuffles along the data from the driver however.

@viniciusban
Copy link
Contributor Author

Indeed. :-(

@stevepiercy
Copy link
Member

Huh, that's interesting. Using PyCharm's database browser on the database tutorial.sqlite, it shows data as type INTEGER. I expected TEXT.

I'll want to review all these docs again as I am certain there are more occurrences such as in the output of database initialization, but I'll create a new issue and do that in another PR.

@stevepiercy stevepiercy merged commit 73589aa into Pylons:master May 21, 2016
@stevepiercy
Copy link
Member

Thanks @viniciusban

@viniciusban
Copy link
Contributor Author

Anytime, Sir.

stevepiercy added a commit to stevepiercy/pyramid that referenced this pull request May 22, 2016
stevepiercy added a commit to stevepiercy/pyramid that referenced this pull request May 22, 2016
stevepiercy added a commit to stevepiercy/pyramid that referenced this pull request May 23, 2016
stevepiercy added a commit that referenced this pull request May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants