Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synch source files with cookiecutter #3192

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Synch source files with cookiecutter #3192

merged 1 commit into from
Oct 30, 2017

Conversation

stevepiercy
Copy link
Member

No description provided.

@stevepiercy
Copy link
Member Author

RE: Pylons/pyramid-cookiecutter-alchemy#24

@stevepiercy
Copy link
Member Author

Anyone know how to fix the builds for this PR and #3193 and #3194, or should I just ignore and merge them?

@stevepiercy
Copy link
Member Author

Per IRC, @bertjwregeer suggested that a new version of flake8 was the culprit, and I found the release notes that matched the new error. See:

Should I insert an exclusion for E722?
https://github.com/Pylons/pyramid/blob/master/setup.cfg#L59

Or should the code be updated?

@digitalresistor
Copy link
Member

I need to take a closer look, but likely we should update the code.

@stevepiercy stevepiercy merged commit 0042089 into Pylons:master Oct 30, 2017
@stevepiercy
Copy link
Member Author

Yay! It's fixed! Thanks @mmerickel and @bertjwregeer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevepiercy @digitalresistor