Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response headers in the headers toolbar could be incorrect #309

Closed
a3kov opened this issue May 27, 2017 · 0 comments
Closed

Response headers in the headers toolbar could be incorrect #309

a3kov opened this issue May 27, 2017 · 0 comments

Comments

@a3kov
Copy link

a3kov commented May 27, 2017

Since it's possible to modify headers after toolbar tween finished processing, displayed headers could be incomplete or incorrect. Most common example is when headers are modified by a response callback as using callback is the universal way of working with headers, that works regardless of the way response is generated.
If Pylons/pyramid#2622 is fixed (but that is unlikely as far as I see), this issue could be fixed also by moving the response callback tween below toolbar.

a3kov pushed a commit to a3kov/pyramid_debugtoolbar that referenced this issue May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant