Replace own ipaddr module with stdlib ipaddress module #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace own ipaddr module with stdlib ipaddress module, fix unit test, and myself to the CONTRIBUTORS.txt.
mmerickel
requested changes
May 22, 2017
setup.py
Outdated
| @@ -28,6 +28,7 @@ | |||
| 'pyramid_mako>=0.3.1', # lazy configuration loading works | |||
| 'repoze.lru', | |||
| 'Pygments', | |||
| 'ipaddress;python_version<"3.3"', | |||
There was a problem hiding this comment.
This particular syntax is not supported for wheels right now. Please use the environment markers as an extra:
j-carl
force-pushed
the
feature_292-stdlib-ipaddress
branch
from
5fae7cf
to
d9b32d3
Compare
|
Yay!!! |
mmerickel
added a commit
that referenced
this pull request
May 23, 2017
j-carl
added a commit
to j-carl/pyramid_debugtoolbar
that referenced
this pull request
Jun 7, 2017
Remove license statement for IPAddr code, because it isn't used anymore. See Pylons#304
This was referenced Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace own ipaddr module with stdlib ipaddress module, fix unit test,
and myself to the CONTRIBUTORS.txt.
#292