Enforce unicode in transaction note #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2016
Natim
reviewed
Nov 21, 2016
| @@ -94,7 +94,7 @@ def tm_tween(request): | |||
| try: | |||
| t.note(text_(request.path_info)) | |||
| except UnicodeDecodeError: | |||
| t.note("Unable to decode path as unicode") | |||
| t.note(text_("Unable to decode path as unicode")) | |||
There was a problem hiding this comment.
You can probably just use u"Unable to decode path as unicode" or from __future__ import unicode_literals at the begining of the file.
There was a problem hiding this comment.
The u'' is fine. Can someone submit a PR (with a test) and I will cut a release. Otherwise you need to wait for me to find some time.
There was a problem hiding this comment.
Oh sorry I just woke up.... This is fine, no need to update it. I thought this commit was from my previous attempt at fixing the issues.
mmerickel
approved these changes
Nov 21, 2016
| @@ -94,7 +94,7 @@ def tm_tween(request): | |||
| try: | |||
| t.note(text_(request.path_info)) | |||
| except UnicodeDecodeError: | |||
| t.note("Unable to decode path as unicode") | |||
| t.note(text_("Unable to decode path as unicode")) | |||
There was a problem hiding this comment.
Oh sorry I just woke up.... This is fine, no need to update it. I thought this commit was from my previous attempt at fixing the issues.
|
Okay just released 1.1.1. Thanks for the quick PR! |
This was referenced Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like something was left over for #49. Without this fix I was having this error: