render exception views for errors caused by commit/abort #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerickel
force-pushed
the
handle-boundary-exceptions
branch
from
35d187a
to
0246993
Compare
|
This PR solves #62 |
digitalresistor
approved these changes
Jun 7, 2017
|
👍 |
This was referenced Jun 8, 2017
This was referenced Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest issue with moving
pyramid_tmOVER the exception view tween was that errors caused by commit/abort were no longer caught and handled. This PR fixes that issue by wrapping commit/abort operations and usingrequest.invoke_exception_viewto turn those errors into responses. It is careful not to catch any other errors and allows them to propagate after successful abort.This feature only works on Pyramid >= 1.7 where
request.invoke_exception_viewwas added.