Draft: Starting exposing A,B,C and the cosines to PWDocument generated inputs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrodelugas
changed the title
* reads bravais_index and use_alternative attributes from the atomic_structure element and uses them to select an ibrav * uses the cell vectors to compute A,B,C COSAB, COSBC and COSCA parameters status
brunato
force-pushed
the
develop
branch
2 times, most recently
from
d3461ac
to
7c25567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging these changes when ibrav is specified in the atomic_structure element of the XML input the input will be written using ibrav and the lattice parameters via the A, B. C, COSAB, COSBC, and COSAC variables
starts solving issue #6 by @afonari