Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing options for lowhighType enumeration #17

Closed
wants to merge 1 commit into from

Conversation

sphuber
Copy link
Collaborator

@sphuber sphuber commented Apr 11, 2023

The disk_io input supports (currently at least) 5 different values:

  • high
  • medium
  • low
  • nowf
  • none

See documentation https://www.quantum-espresso.org/Doc/INPUT_PW.html#idm128 The input is represented in the XML schema by the lowhighType which only includes the low and high options though, causing parsing of calculations done with any of the other options to fail. Here the missing options are added.

The `disk_io` input supports (currently at least) 5 different values:

* `high`
* `medium`
* `low`
* `nowf`
* `none`

See documentation https://www.quantum-espresso.org/Doc/INPUT_PW.html#idm128
The input is represented in the XML schema by the `lowhighType` which only includes
the `low` and `high` options though, causing parsing of calculations done with any of the
other options to fail. Here the missing options are added.
@sphuber
Copy link
Collaborator Author

sphuber commented Apr 11, 2023

@pietrodelugas Not sure whether the PW_CPV/qes_current_master.xsd file should also be updated. Also, need the older versions be fixed retroactively, since they also have an incomplete enumeration in the schema. Or will that be ineffective?

All the schemas that we include with aiida-quantumespresso only have the low and high options. So as far as I can tell, I think all schemas going back to at least qes_190304.xsd are affected.

@pietrodelugas
Copy link
Member

I have added this changes in MR #18 that has been just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants