Qgep swmm phase3 enhancements #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…each_coefficient_of_friction
force 3D geom vw_conduites
6648 import backflow level
add X,Y location for raingages
698 pipe profils
change to export special structures
720 729 network selection
compute roughness using Strickler or Colebrook vw_conduites
728 populate default friction
ponceta
requested review from
sjib and
olivierdalang
and removed request for
sjib
sjib
reviewed
Dec 13, 2022
sjib
reviewed
Dec 13, 2022
sjib
reviewed
Dec 13, 2022
sjib
reviewed
Dec 13, 2022
sjib
reviewed
Dec 13, 2022
sjib
reviewed
Dec 13, 2022
sjib
reviewed
Dec 13, 2022
ponceta
added
the
feature
sjib
approved these changes
Jan 23, 2023
|
@olivierdalang do we want to have it in 1.5.7 or is 1.5.8 fine (we should then publish a 1.5.7 release with the few fixes that we brought in the meantime)? |
|
We have to fix 1.5.7 and continuous integration and we will be ready to add this to 1.5.8 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages and warning
• Most of the message regarding computation of values (roughness, dry weather flow) are migrated in the SWMM descriptions of the objects
• Info, warnings and errors are printed in the processing interface in QGIS
Catchment redirection
• See issue QGEP/QGEP#730 and QGEP/QGEP#560
Reach roughness:
• See issues QGEP/QGEP#727 and QGEP/QGEP#728
Special structures:
• See issue QGEP/QGEP#719
• Export pump curve
• Export tank storage curve
• Modelise prank weirs as outlet with curve
Selection
• See issue QGEP/QGEP#720 and QGEP/QGEP#729
• Export selected network (included secondary)
Add raingage location
• Related to issue QGEP/QGEP#646
Solve bug with the export of land use