Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication of files + label IDs should be fixed #44

Closed
fedorov opened this issue Jul 20, 2016 · 0 comments · Fixed by #65
Closed

Communication of files + label IDs should be fixed #44

fedorov opened this issue Jul 20, 2016 · 0 comments · Fixed by #65
Assignees
Labels

Comments

@fedorov
Copy link
Member

fedorov commented Jul 20, 2016

When ITK labels are converted to DICOM, there may be multiple labels per single ITK label file. Therefore, we need a combination of file (or itkImageData) and label ID to do the conversion properly.

Currently, this is not reflected in the SEG schema, and probably not in the API.

Open question is how file list should be communicated in the JSON. Options:

  1. Pass file list outside of JSON, have groups of segment groups, where each group maps to the position of the input label file, and within each group labelID maps to the individual label value within that file. This maps more cleanly into the API use case, since segment groups can the same way map to the position of the itkImageData in the vector passed to the API.
  2. Include file name directly in the segment group. To be used with the API, without file IO, JSON will need to be modified before it is passed downstream.
@fedorov fedorov added the bug label Jul 20, 2016
@fedorov fedorov self-assigned this Jul 20, 2016
@che85 che85 added this to the SR/SEG/PM converters release milestone Aug 16, 2016
fedorov added a commit to fedorov/dcmqi that referenced this issue Aug 17, 2016
re QIICR#44: segmentAttributes in metadata now consists of the outer list, where each item
corresponds to the input itkImage, and is a list itself. The items of the inner
list contain the attributes of the segments, identified by labelID which maps to
the input image pixel values.
fedorov added a commit to fedorov/dcmqi that referenced this issue Aug 17, 2016
re QIICR#44: segmentAttributes in metadata now consists of the outer list, where each item
corresponds to the input itkImage, and is a list itself. The items of the inner
list contain the attributes of the segments, identified by labelID which maps to
the input image pixel values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants