Add handling of multiple labels per input image file #65
Conversation
|
@che85 let me know if you have concerns note that this PR will require changes to the webapp to handle list of segment attributes lists |
|
@fedorov I worked on the schema as well and made corrections based on the validation tools. It would make more sense to first merge my changes and adapt your changes to it... |
|
sure, are they very extensive? go ahead with the PR I am working on another PR to add jsonlint testing |
re QIICR#44: segmentAttributes in metadata now consists of the outer list, where each item corresponds to the input itkImage, and is a list itself. The items of the inner list contain the attributes of the segments, identified by labelID which maps to the input image pixel values.
will need to remove later, and put all attributes within at the top level, but too much work to do it now (need to change JSON handler, web app, converter ...)
fedorov
force-pushed
the
44-seg-label-ids
branch
from
14d690e
to
8fcac64
Compare
|
rebased to current master |
| { | ||
| "$ref": "https://raw.githubusercontent.com/qiicr/dcmqi/master/doc/common-schema.json#/definitions/PN" | ||
| "$ref":"https://raw.githubusercontent.com/qiicr/dcmqi/master/doc/common-schema.json#/definitions/PN" |
There was a problem hiding this comment.
@fedorov Why are you removing all those spaces? It's general json syntax to have
"key": "value"
Even when you use a library for generating JSON it always comes out that way. Maybe it's a matter of taste but let's try keep it one way.
http://www.jsonschemavalidator.net/ also formats the way I mentioned.
There was a problem hiding this comment.
It's just what the formatter I used generated: https://jsonformatter.curiousconcept.com/
I will run in http://www.jsonschemavalidator.net/ and update
There was a problem hiding this comment.
Oh didn't know that you are also using one :)
Supposed to resolve #44