New distribution: ParticleDistribution #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
|
Thanks, this looks like a very good start on #105! I'll look over and see if I have any concrete suggestions, but after a cursory look, I think it's great. Before merging, I'd like to fix the Travis build error, though. It looks like it's unrelated to this PR, but is happening due to changes in QuTiP upstream; now that 4.0 is out, we should be able to make the doctest build more stable, so I'll go on and take care of that in a separate PR soon. Thanks! |
This was referenced Feb 1, 2017
1 similar comment
cgranade
approved these changes
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the new distribution
ParticleDistributionand corresponding tests. All methods and properties ofSMCUpdaterwhich were (in my opinion) relevant to a bare particle distribution were copied over (but left intact). This is the first step of #105. The next step, in my view, is to implement the hierarchyParticleDistribution>AbstractUpdater>SMCUpdater.It would be worthwhile for someone to compare the properties and methods of
ParticleDistributionandSMCUpdaterto check if my choices are appropriate and comprehensive.[Sorry for all the whitespace changes my text editor did automatically]