Feature: ProductDomain #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value set of finite domain factors
cgranade
requested changes
Mar 22, 2017
| :type: ``int`` or ``np.inf`` | ||
| """ | ||
| if self.is_finite: | ||
| return reduce(mul, [domain.n_members for domain in self._domains], 1) |
There was a problem hiding this comment.
This line is raising a Py3 compatibility warning; should be able to fix by importing reduce from functools.
| # taken from http://stackoverflow.com/questions/5355744/numpy-joining-structured-arrays | ||
| sizes = np.array([a.itemsize for a in arrays]) | ||
| offsets = np.r_[0, sizes.cumsum()] | ||
| shape = arrays[0].shape |
There was a problem hiding this comment.
arrays is being called with the result of map in line 238 of domains.py, but map is not indexible on Python 3. I'd suggest calling list(map(...)) above since that also clears the Py3 warning that's blocking the Travis build.
cgranade
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new domain called
ProductDomainwhich takes the cartesian product of any number of factor domains. This is done using numpy structured dtypes, so you can, for example, take the product ofMultinomialDomainandRealDomainand end up with a dtype like[('k', int, 3), ('f1', float)].This PR should be merged after #116 and #115.