Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docopt #122

Merged
merged 4 commits into from
Mar 24, 2017
Merged

Remove docopt #122

merged 4 commits into from
Mar 24, 2017

Conversation

cgranade
Copy link
Collaborator

This PR completely removes docopt from _lib since we're no longer using it at all.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.4%) to 71.76% when pulling d0d6451 on remove-docopt into ad5be44 on master.

@cgranade
Copy link
Collaborator Author

Since this passes all tests, I think that's a pretty good indication that there's not any dependencies on docopt that I missed. Should be ready to merge in once #121 is merged.

@ihincks
Copy link
Collaborator

ihincks commented Mar 23, 2017

Would you mind just triggering a travis rebuild to be safe? I usually do `git commit --allow-empty -m ..", but apparently the travis website also has a refresh button for those with admin access.

@cgranade
Copy link
Collaborator Author

Sounds good, will do. I apologize about not exposing the "Restart build" option, there doesn't seem to be a way to delegate or share access to the Travis build controls. One workaround I've found that's a bit of a pain is to use your own fork of the repo so that you have direct control over Travis on that fork. Certainly not a great option, though, given that you really should just have access to build controls directly.

@cgranade
Copy link
Collaborator Author

Looks like the tests still pass under the fresh build, so I think that's a pretty good indication that we haven't missed anything.

Copy link
Collaborator

@ihincks ihincks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@ihincks ihincks merged commit 8118ab7 into master Mar 24, 2017
@cgranade cgranade deleted the remove-docopt branch March 24, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants