-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove docopt #122
Remove docopt #122
Conversation
Since this passes all tests, I think that's a pretty good indication that there's not any dependencies on docopt that I missed. Should be ready to merge in once #121 is merged. |
Would you mind just triggering a travis rebuild to be safe? I usually do `git commit --allow-empty -m ..", but apparently the travis website also has a refresh button for those with admin access. |
Sounds good, will do. I apologize about not exposing the "Restart build" option, there doesn't seem to be a way to delegate or share access to the Travis build controls. One workaround I've found that's a bit of a pain is to use your own fork of the repo so that you have direct control over Travis on that fork. Certainly not a great option, though, given that you really should just have access to build controls directly. |
Looks like the tests still pass under the fresh build, so I think that's a pretty good indication that we haven't missed anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
This PR completely removes docopt from
_lib
since we're no longer using it at all.