Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #126

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Build fixes #126

wants to merge 4 commits into from

Conversation

MichalKononenko
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 71.749% when pulling 5199592 on MichalKononenko:BuildFixes into 8118ab7 on QInfer:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 71.749% when pulling 5199592 on MichalKononenko:BuildFixes into 8118ab7 on QInfer:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 71.749% when pulling 5199592 on MichalKononenko:BuildFixes into 8118ab7 on QInfer:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 71.749% when pulling 5199592 on MichalKononenko:BuildFixes into 8118ab7 on QInfer:master.

@cgranade
Copy link
Collaborator

It's pretty critical to have qinfer.__version__ defined in released builds, so I'd like to figure out how to either fix the builds or fail gracefully if version.py isn't properly created by setup.py. (Possibly both.) For instance, we may be able to modify __init__.py similar to the following:

try:
    from qinfer.version import version as __version__
except ImportError:
    __version__ = '<unknown>'

That would break a few things based on version comparisons, but if one uses distutils.version.LooseVersion, that should still at least give somewhat sensible answers:

>>> LooseVersion('<unknown>') < LooseVersion('1.0')
False
>>> LooseVersion('<unknown>') > LooseVersion('1.0')
True

As for build breakages, I'm seeing some builds failing due to QuTiP 4.1 now requiring a C++ compiler, such that we do need to fix those builds, but is there a specific build that you saw break due to version.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants