Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug of opening a graphic file #399

Closed
salmivas opened this issue Oct 17, 2018 · 11 comments
Closed

Bug of opening a graphic file #399

salmivas opened this issue Oct 17, 2018 · 11 comments
Labels

Comments

@salmivas
Copy link

Hello!

I can't open this graphic file via the program:
transylvania romania 1920x1080
When I'm trying to open it, I just see an empty window like this:
image

All over wallpapers (Windows spotlight pictures) are simply opened by the program.

@bieladeka
Copy link

I'd like to solve this bug

@xupefei
Copy link
Member

xupefei commented Oct 17, 2018

image
Works for me.

@salmivas
Copy link
Author

Works for me.

It works for me as well If I just "save image as" after clicking on it. But try to download original files and open them. What will you see?

@bieladeka
Copy link

Yes I have same problem, after opening original files
wrongfile

@xupefei xupefei added the bug label Oct 25, 2018
@bieladeka
Copy link

How can I debug QuickLook.Plugin.ImageViewer.csproj? I made changes, but I don't know, how to verify the correctness,
THX

@bieladeka
Copy link

Bug is in a name of the Image. When you try to rename yours original files, then it works.
Now I am working on handling a name of the image object. Any ideas where I can find it in the code ?

@bieladeka
Copy link

In the same time a predefined size parameters are missing, so maybe there is also some size misunderstood

differencies

@bieladeka
Copy link

Definitely, bug is in a name of an image, NConverter.exe cannot handle Image with name (from Original files) and process.standardoutput.readtoend() return state Failed. NConverter.exe is external, so I can't debug it and solve that from the bottom.
One option is rename Image with some function to a similar name, but I don't know if users will be satisfied, what do you think?

@xupefei
Copy link
Member

xupefei commented Nov 7, 2018

This is not QL's fault.
As @bieladeka said, there are special (invisible) characters in the file name:
image

image

Just rename the file and everything will be okay.

@xupefei xupefei closed this as completed Nov 7, 2018
bieladeka pushed a commit to bieladeka/QuickLook that referenced this issue Nov 7, 2018
@bieladeka
Copy link

Despite that, I fixed it after creating copy of an origin file in temp files and then opening that temp file in QuickLook. Please take a look at pushed commit (only last) in bieladeka/QuickLook. THX

@xupefei
Copy link
Member

xupefei commented Nov 8, 2018

The regular expression you are using covers only Latin-family languages. World languages go far beyond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants