Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMC densities have incorrect weight (CPU code) #934

Open
prckent opened this issue Jul 18, 2018 · 2 comments
Open

DMC densities have incorrect weight (CPU code) #934

prckent opened this issue Jul 18, 2018 · 2 comments
Labels

Comments

@prckent
Copy link
Contributor

prckent commented Jul 18, 2018

Per the report in #925 , the weight in the first block of the DMC AoS code is incorrect. This is a definite bug and needs to be fixed in AoS and SoA. A similar fix may be needed in the CUDA code, but an additional bug is likely present there.

@prckent prckent added the bug label Jul 18, 2018
@prckent prckent added this to the V3.5.1 Release milestone Aug 1, 2018
@jtkrogel
Copy link
Contributor

I wonder if this is related to the remaining first step weights issue in #789. See the last "Trace of trial energy" plot there. The spikes right at the beginning of each DMC could relate to improper handling of the weights as is seen in the density estimator.

@jtkrogel jtkrogel mentioned this issue Sep 11, 2018
12 tasks
@prckent prckent modified the milestones: V3.5.1 Release, V3.6.0 Release Nov 7, 2018
@jtkrogel
Copy link
Contributor

In regards to what might be special about the first DMC block, I noticed the following during some data analysis.

The number of walkers fluctuates little in the first block, and much more in other blocks:
nwalkers_trace

The weight varies even less (almost none) than the walker count in the first block (look for the short horizontal line at the beginning of each series):
weight_trace

The trial energy is absolutely bonkers for this block, likely reflecting the extreme population control needed to constrain the weights as above:
trial_energy_trace

Conclusion: extreme population control in the first block to blame for the incorrect weights in that block? Thoughts @ye-luo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants