New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMC densities have incorrect weight (CPU code) #934

Open
prckent opened this Issue Jul 18, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@prckent
Contributor

prckent commented Jul 18, 2018

Per the report in #925 , the weight in the first block of the DMC AoS code is incorrect. This is a definite bug and needs to be fixed in AoS and SoA. A similar fix may be needed in the CUDA code, but an additional bug is likely present there.

@prckent prckent added the bug label Jul 18, 2018

@prckent prckent added this to the V3.5.1 Release milestone Aug 1, 2018

@jtkrogel

This comment has been minimized.

Contributor

jtkrogel commented Aug 18, 2018

I wonder if this is related to the remaining first step weights issue in #789. See the last "Trace of trial energy" plot there. The spikes right at the beginning of each DMC could relate to improper handling of the weights as is seen in the density estimator.

@jtkrogel jtkrogel referenced this issue Sep 11, 2018

Open

Universally failing tests #1058

0 of 12 tasks complete

@prckent prckent modified the milestones: V3.5.1 Release, V3.6.0 Release Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment