-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMC densities have incorrect weight (CPU code) #934
Comments
I wonder if this is related to the remaining first step weights issue in #789. See the last "Trace of trial energy" plot there. The spikes right at the beginning of each DMC could relate to improper handling of the weights as is seen in the density estimator. |
In regards to what might be special about the first DMC block, I noticed the following during some data analysis. The number of walkers fluctuates little in the first block, and much more in other blocks: The weight varies even less (almost none) than the walker count in the first block (look for the short horizontal line at the beginning of each series): The trial energy is absolutely bonkers for this block, likely reflecting the extreme population control needed to constrain the weights as above: Conclusion: extreme population control in the first block to blame for the incorrect weights in that block? Thoughts @ye-luo? |
Per the report in #925 , the weight in the first block of the DMC AoS code is incorrect. This is a definite bug and needs to be fixed in AoS and SoA. A similar fix may be needed in the CUDA code, but an additional bug is likely present there.
The text was updated successfully, but these errors were encountered: