Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Tmove v3 option algorithm #1288

Merged
merged 24 commits into from
Jan 3, 2019

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Dec 28, 2018

As updated in the manual.

The old algorithm

v3 reuses the transition probability computed in non-local pseudopotentials, namely before accepting any T-moves.

The new one

v3 mostly reuses the transition probability computed during the evaluation of non-local pseudopotentials for the local energy, namely before accepting any T-moves, and only recomputes the transition probability of the electrons within the same pseudopotential region of any electrons touched by T-moves.

v1 and v3 is not numerically equivalent but I got negligible difference in both molecules and solids with the new v3.

v3 faster algorithm will be the topic of a paper currently in preparation.

Additional changes:
New tests based on NiO are included. Closes #630
Merge the replicated code for CPU and GPU used by v0.

@ghost ghost assigned ye-luo Dec 28, 2018
@ghost ghost added the in progress label Dec 28, 2018
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates to this new algorithm.

@prckent prckent merged commit 75430a1 into QMCPACK:develop Jan 3, 2019
@ghost ghost removed the in progress label Jan 3, 2019
@ye-luo ye-luo deleted the spline-based-tmove-tests-NiO branch February 2, 2019 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants