Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nexus: use OS environment by default #3108

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Nexus: use OS environment by default #3108

merged 1 commit into from
Apr 15, 2021

Conversation

jtkrogel
Copy link
Contributor

Proposed changes

Addresses issues faced in #3100.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Ubuntu Docker image on laptop.

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@jtkrogel jtkrogel mentioned this pull request Apr 15, 2021
Merged
@qmc-robot
Copy link

Can one of the admins verify this patch?

@prckent
Copy link
Contributor

prckent commented Apr 15, 2021

OK to test

prckent
prckent approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent prckent merged commit c21e516 into QMCPACK:develop Apr 15, 2021
@prckent prckent mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtkrogel @qmc-robot @prckent