-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus: Generate PySCF inputs without template #3550
Nexus: Generate PySCF inputs without template #3550
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test for input generation in tests/unit/test_pyscf_input.py
, function test_generate
. You should be able to just copy and then generalize an existing test, now including the calculation
input and any others added.
Thank you, Jaron. Unit tests have been added and I have addressed all your comments above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test this please |
Proposed changes
This PR extends
pyscf_input.py
to allow template-less workflows. The user can now specify acalculation
object with variables that contain information about the run, e.g.What type(s) of changes does this code introduce?
Does this introduce a breaking change?
nxs-test
tests pass.What systems has this change been tested on?
Laptop
Checklist