Multideterminant Batch code [Part 3 of Offload] #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this please |
… into MSD-Offload_Part3
anbenali
changed the title
ye-luo
reviewed
Mar 7, 2022
ye-luo
reviewed
Mar 7, 2022
|
Test this please |
|
All requests from @ye-luo addressed. Once this is merged, It will be the baseline for comparing performance. |
|
Test this please |
ye-luo
reviewed
Mar 7, 2022
|
Test this please |
prckent
requested changes
Mar 9, 2022
There was a problem hiding this comment.
Very very minor request: I understand that the ///PRAGMA OFFLOAD comments are for part 4, but please tidy:
///This function needs really to be ported...
and any similar commentary in the touched source code. These have a habit of remaining for a long time and lose context.
|
@prckent : Comments are removed |
|
Test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
All variables in Batched Multideterminant implementation have a dual view, host and device.
Multiple functions related to Phi->evaluateXXX do not have a batched or GPU implementations and required to send only the host view. Following those calls require either to send the result to the device using the
XXX.updateTo()function or later, for those values to be computed on the GPU directly.This PR belongs to the general effort aiming at generating a GPU implementation of the multideterminant code. #3830
This is part 3: All Variables needed by Table method have dual View Host/Device.
What type(s) of changes does this code introduce?
Delete the items that do not apply
Refactoring (no functional changes, no api changes)
Other (please describe): GPU capability
Does this introduce a breaking change?
What systems has this change been tested on?
Laptop
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.