Reflect HIP build options in printout #3919
Conversation
ENABLE_ROCM is a CMake option not a macro. It should not be used in the source codes.
|
Test this please |
src/QMCApp/QMCMain.cpp
Outdated
| app_summary() << " CPU only build" << std::endl; | ||
| #else | ||
| #if defined(ENABLE_OFFLOAD) | ||
| app_summary() << " OpenMP target offload to accelerators build option is enabled" << std::endl; | ||
| #endif | ||
| #if defined(ENABLE_CUDA) || defined(QMC_CUDA) | ||
| #if defined(ENABLE_HIP) || defined(QMC_CUDA2HIP) |
There was a problem hiding this comment.
This is probably out of scope for this PR.
We have too many hip options. If ENABLE_HIP is on QMC_CUDA2HIP must be on since you are by definition on a HIP system and if the CUDA is built it will be broken.
I don't see any good reason to allow QMC_CUDA2HIP and not ENABLE_HIP.
However as long as all those options exist and can be used in different combination they should probably give separate output. Otherwise you need to have access to the build options to really know what you are running anyway.
There was a problem hiding this comment.
That is not true. ENABLE_HIP is direct HIP source code in AFQMC.
There was a problem hiding this comment.
@PDoakORNL how about the current printout?
|
Test this please |
Proposed changes
ENABLE_ROCM is a CMake option not a macro. It should not be used in the source codes.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist