Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexus: add twist_info.dat files to results directory #4302

Merged
merged 3 commits into from
Nov 5, 2022

Conversation

camelto2
Copy link
Contributor

@camelto2 camelto2 commented Nov 2, 2022

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Adds twist_info files to be copied to the results directory. This is useful in order to do weighted twist averaging with qmca (which reads the weights from these files) from the nexus results directory if it isn't the same as the 'runs' directory.

Closes #4301

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

mac

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@camelto2 camelto2 changed the title add twist_info.dat files to results dir nexus: add twist_info.dat files to results dir Nov 2, 2022
@camelto2 camelto2 added the nexus label Nov 2, 2022
@camelto2 camelto2 changed the title nexus: add twist_info.dat files to results dir nexus: add twist_info.dat files to results directory Nov 2, 2022
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent
Copy link
Contributor

prckent commented Nov 4, 2022

Test this please

@ye-luo
Copy link
Contributor

ye-luo commented Nov 4, 2022

Test this please

@prckent prckent merged commit 5b19116 into QMCPACK:develop Nov 5, 2022
@camelto2 camelto2 deleted the nxs_twist_info_results branch March 16, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twist_info files not copied to results
3 participants