qmc-fit: Added equation of states and morse fits with jackknife - #4518
Merged
Conversation
prckent
reviewed
Mar 17, 2023
Contributor
Author
|
Contributor
|
Great. Can you add an initial manual entry in this PR? The rest can be done subsequently imo. As background to my comments and thinking, I have some general concerns about our python-based tools and NEXUS-related contributions that we need to find a way to tackle. None are specific to this PR!
|
prckent
approved these changes
Mar 23, 2023
prckent
left a comment
Contributor
There was a problem hiding this comment.
Confirmed html and PDF generation are OK locally.
Thanks Kayahan.
Contributor
|
Test this please |
Contributor
Author
|
Thanks Paul, I will be adding the unit test as well. |
Contributor
|
Test this please |
Contributor
|
Test this please |
ye-luo
enabled auto-merge
April 3, 2023 21:47
Contributor
|
Keep this moving and I added #4539 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equation of states and morse potential fitting capabilities are added to qmc-fit. Morse fit was available in numerics.py, but it was not user-friendly, therefore it is wrapped in qmc-fit. Other equation of state fits (Vinet, Birch, Murnaghan) didn't have jackknife fitting capabilities, hence such capability is added in this PR. The code is tested with nxs-test, but the existing qmc-fit tests do not cover these new capabilities.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
macOS Monterey 12.6.3, Python 3.9.13
Checklist