-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qmc-fit: Added equation of states and morse fits with jackknife #4518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What are your plans to document this?
- How is this tested? I think some run calling these capabilities is required, e.g. via extensions of qmc-fit tests.
|
Great. Can you add an initial manual entry in this PR? The rest can be done subsequently imo. As background to my comments and thinking, I have some general concerns about our python-based tools and NEXUS-related contributions that we need to find a way to tackle. None are specific to this PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed html and PDF generation are OK locally.
Thanks Kayahan.
Test this please |
Thanks Paul, I will be adding the unit test as well. |
Test this please |
Test this please |
Keep this moving and I added #4539 |
Equation of states and morse potential fitting capabilities are added to qmc-fit. Morse fit was available in numerics.py, but it was not user-friendly, therefore it is wrapped in qmc-fit. Other equation of state fits (Vinet, Birch, Murnaghan) didn't have jackknife fitting capabilities, hence such capability is added in this PR. The code is tested with nxs-test, but the existing qmc-fit tests do not cover these new capabilities.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
macOS Monterey 12.6.3, Python 3.9.13
Checklist