Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Be orbital optimization test #4626

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

markdewing
Copy link
Contributor

Some fixes for #4619:

  1. Check correct series number.
  2. Skip test for mixed precision builds.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Bugfix
  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

desktop

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • N/A. Code added or changed in the PR has been clang-formatted
  • Yes. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • N/A. Documentation has been added (if appropriate)

Check correct series number.
Skip test for mixed precision builds.
@markdewing
Copy link
Contributor Author

Test this please

@prckent prckent merged commit 0c5f85c into QMCPACK:develop Jun 6, 2023
@markdewing markdewing deleted the be_orb_opt_mixed_prec branch June 6, 2023 14:46
@prckent prckent mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants