Repository navigation
Disable Estimator tests if BUILD_UNIT_TESTS is set to OFF. - #4709
Merged
prckent merged 1 commit intoAug 24, 2023
Merged
Conversation
prckent
self-requested a review
August 24, 2023 13:27
prckent
approved these changes
Aug 24, 2023
prckent
left a comment
Contributor
There was a problem hiding this comment.
Thanks Stephan.
Looks good to me. I think this was not caught before since it is a rarely used config option.
Contributor
|
Test this please |
prckent
enabled auto-merge
August 24, 2023 13:40
Contributor
|
On which OS system and with what compiler , the linking failed? |
Contributor
Author
It failed on ubuntu-20 with intel oneAPI 2023.2.0 compiler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
The 'test_estimators' binary is build independent of the setting of BUILD_UNIT_TESTS. This causes a linker error as 'sposets_for_testing' library is not available. Disable tests for Estimators if BUILD_UNIT_TESTS is OFF.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist