Skip to content

Disable Estimator tests if BUILD_UNIT_TESTS is set to OFF. - #4709

Merged
prckent merged 1 commit into
QMCPACK:developfrom
stephan-rohr:disable_estimators_unit_tests
Aug 24, 2023
Merged

prckent merged 1 commit into
QMCPACK:developfrom
stephan-rohr:disable_estimators_unit_tests

Conversation

@stephan-rohr

Copy link
Copy Markdown
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

The 'test_estimators' binary is build independent of the setting of BUILD_UNIT_TESTS. This causes a linker error as 'sposets_for_testing' library is not available. Disable tests for Estimators if BUILD_UNIT_TESTS is OFF.

What type(s) of changes does this code introduce?

  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@prckent
prckent self-requested a review August 24, 2023 13:27

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stephan.

Looks good to me. I think this was not caught before since it is a rarely used config option.

@prckent

prckent commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Test this please

@prckent
prckent enabled auto-merge August 24, 2023 13:40
@ye-luo

ye-luo commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

On which OS system and with what compiler , the linking failed?

@stephan-rohr

Copy link
Copy Markdown
Contributor Author

On which OS system and with what compiler , the linking failed?

It failed on ubuntu-20 with intel oneAPI 2023.2.0 compiler.

@prckent
prckent merged commit e5dfe55 into QMCPACK:develop Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants