Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker dependecies in application code #457

Open
zetoph opened this issue Feb 11, 2020 · 3 comments
Open

Remove docker dependecies in application code #457

zetoph opened this issue Feb 11, 2020 · 3 comments
Milestone

Comments

@zetoph
Copy link
Contributor

zetoph commented Feb 11, 2020

Some QMSTR functionality is currently implemented in the go application code using the golang docker library. In order to enable flexible deployments and configuration, these dependencies should be eliminated from the application and shifted to known tools (such as helm, docker cli, docker-compose, kubectl)

@zetoph zetoph self-assigned this Feb 11, 2020
@zetoph zetoph added the enhancement New feature or request label Feb 11, 2020
@zetoph zetoph changed the title Externalize Dgraph from QMSTR master image Remove docker dependecies in application code Feb 26, 2020
@zetoph
Copy link
Contributor Author

zetoph commented Feb 26, 2020

% grep -R "github.com/QMSTR/qmstr/lib/go-qmstr/docker" ./       
./lib/go-qmstr/cli/copy.go:	"github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/log.go:	"github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/snapshot.go:	"github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/spawn.go:	"github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/start.go:	"github.com/QMSTR/qmstr/lib/go-qmstr/docker"
./lib/go-qmstr/cli/quit.go:	"github.com/QMSTR/qmstr/lib/go-qmstr/docker"
Binary file ./out/qmstrctl matches
../lib/go-qmstr/cli/copy.go:	"github.com/docker/docker/client"
../lib/go-qmstr/cli/log.go:	"github.com/docker/docker/client"
../lib/go-qmstr/cli/clean.go:	"github.com/docker/docker/client"
../lib/go-qmstr/cli/snapshot.go:	"github.com/docker/docker/client"
../lib/go-qmstr/cli/spawn.go:	"github.com/docker/docker/client"
../lib/go-qmstr/cli/start.go:	"github.com/docker/docker/client"
../lib/go-qmstr/cli/quit.go:	"github.com/docker/docker/client"
../lib/go-qmstr/docker/copy.go:	"github.com/docker/docker/client"
../lib/go-qmstr/docker/master.go:	"github.com/docker/docker/client"
../lib/go-qmstr/docker/client.go:	"github.com/docker/docker/client"

@fullsushidev
Copy link
Contributor

I think this is already done, right @marcomicera ?

@fullsushidev fullsushidev added this to the Cleanup milestone Oct 5, 2020
@marcomicera
Copy link
Member

Such a grep still shows some occurrences of that module. I'll look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants