Skip to content

Conversation

a-andreyev
Copy link
Contributor

Contributes to issue #513
I like this HSL-based appoarch so tried to help (implemented similar for r0kk3rz Sailfish OS version), but feel to reject/correct :)

Checked with different KDE color schemes:

Imgur

@KitsuneRal
Copy link
Member

KitsuneRal commented Mar 4, 2019

Thanks for the start! And yes, HSL-based calculation is certainly the way to go. We have a few more tasks ahead though :)

@a-andreyev a-andreyev force-pushed the aa13q-fancy-colors branch from 6a285c8 to e315ab5 Compare March 5, 2019 23:06
@KitsuneRal KitsuneRal added the enhancement A feature or change request for Quaternion label Mar 6, 2019
@a-andreyev
Copy link
Contributor Author

current results screenshot:

Imgur

@KitsuneRal
Copy link
Member

Now that we have the lib PR, it's time to rebase this PR on the newest master :)

Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be really trivial now that the library does all the heavy-lifting. Let's do it!

@a-andreyev a-andreyev force-pushed the aa13q-fancy-colors branch from 7ce1090 to 4d17151 Compare May 14, 2019 12:10
@a-andreyev
Copy link
Contributor Author

rebased and testing, getting black color for now (checking what versrion I've compiled)

@a-andreyev a-andreyev force-pushed the aa13q-fancy-colors branch from 4d17151 to a6191ab Compare May 15, 2019 02:05
@a-andreyev
Copy link
Contributor Author

working now, but I have a boilerplate code for final color calculation from hue: for UserListDock widget c++ part and TimelineItem qml part. Not sure yet where's better place to provide shared solution 🤔

@a-andreyev a-andreyev force-pushed the aa13q-fancy-colors branch from a6191ab to 34abba2 Compare May 15, 2019 02:21
@KitsuneRal
Copy link
Member

KitsuneRal commented May 15, 2019

At the moment, all CI pipelines are breaking because you seem to have forgotten to add the newest lib to your commit. In order to do that, you have to make sure the contents under lib/ subdirectory are at the right commit (basically - the newest commit in master) and then commit the subdirectory itself (and push the commit, of course).

@a-andreyev a-andreyev force-pushed the aa13q-fancy-colors branch from 34abba2 to 18a41fb Compare May 15, 2019 10:32
@KitsuneRal
Copy link
Member

working now, but I have a boilerplate code for final color calculation from hue: for UserListDock widget c++ part and TimelineItem qml part. Not sure yet where's better place to provide shared solution 🤔

Well, a fancy way of doing it would be to introduce a Quaternion-specific user class (QuaternionUser) instead of the generic QMatrixClient::User (Connection allows you to customise the class it uses to create user objects) and provide QuaternionUser::color() that also backs a Q_PROPERTY so that it could be referred to from QML. If that sounds a bit too much for you, just leave the boilerplate - we'll get back to it sometime later.

@a-andreyev
Copy link
Contributor Author

If that sounds a bit too much for you, just leave the boilerplate - we'll get back to it sometime later.

Probably a bit too much but sounds interesting 🙂 Agree to leave it for now and save the task as an issue for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for Quaternion
Projects
Status: Version 0.0.95 - Done
Development

Successfully merging this pull request may close these issues.

2 participants