-
Notifications
You must be signed in to change notification settings - Fork 108
Use colour-coding for user disambiguation #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the start! And yes, HSL-based calculation is certainly the way to go. We have a few more tasks ahead though :)
|
6a285c8
to
e315ab5
Compare
Now that we have the lib PR, it's time to rebase this PR on the newest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be really trivial now that the library does all the heavy-lifting. Let's do it!
Contributes to issue quotient-im#513
7ce1090
to
4d17151
Compare
rebased and testing, getting black color for now (checking what versrion I've compiled) |
4d17151
to
a6191ab
Compare
working now, but I have a boilerplate code for final color calculation from hue: for |
a6191ab
to
34abba2
Compare
At the moment, all CI pipelines are breaking because you seem to have forgotten to add the newest lib to your commit. In order to do that, you have to make sure the contents under |
34abba2
to
18a41fb
Compare
Well, a fancy way of doing it would be to introduce a Quaternion-specific user class ( |
Probably a bit too much but sounds interesting 🙂 Agree to leave it for now and save the task as an issue for example |
Contributes to issue #513
I like this HSL-based appoarch so tried to help (implemented similar for r0kk3rz Sailfish OS version), but feel to reject/correct :)
Checked with different KDE color schemes: