Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpi diff 1 #18

Draft
wants to merge 9 commits into
base: rc-0.3
Choose a base branch
from
Draft

Fix gpi diff 1 #18

wants to merge 9 commits into from

Conversation

Gabriel-Bottrill
Copy link
Collaborator

@Gabriel-Bottrill Gabriel-Bottrill commented Jun 4, 2024 •
edited
Loading

The following have all been completed:

  • All new or changed features have a related unit test.

  • The entire test suite passes.

  • No extra files have been added by mistake, i.e. .vscode.

  • Style guidelines have been followed.

  • All files have been formatted.

  • Documentation and version number (if applicable) have been updated.

  • All code changed has been clearly written and commented.

Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@Gabriel-Bottrill
Copy link
Collaborator Author

@glassnotes, this is almost ready the gradients are just failing at phi=0, I am in the middle of figuring out why.

@glassnotes
Copy link
Contributor

@Gabriel-Bottrill maybe check out these two issues in PennyLane:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriel-Bottrill @glassnotes