Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find solution for theming #2

Open
oroulet opened this issue Apr 9, 2017 · 12 comments
Open

find solution for theming #2

oroulet opened this issue Apr 9, 2017 · 12 comments

Comments

@oroulet
Copy link
Contributor

oroulet commented Apr 9, 2017

Currently we have a quite harcoded solution. Ideally it should be qml only but things like icons are part of models in qt so I am not sure how to solve that

@fuchsmich
Copy link

Generally QtQuick Controls 1 (Buttons, Menus, etc...) should be decorated by default suitable to the Desktop Environment. But the colors of the currently used theme can also be accessed in qml (e.g. for styling custom items):
http://doc.qt.io/qt-5/qml-qtquick-systempalette.html

At least in KDE if you choose the right "icon-name" in Actions, the according icon appears in Menus and Toolbars (icons can be browsed with cuttlefish (part of kde-sdk)). In Windows this doesnt work for me. I guess we have to deploy some kind of default icon-theme with the app.

@oroulet
Copy link
Contributor Author

oroulet commented Apr 13, 2017

I agree that we should use system theming as much as possible. I use gnome3. And I have absoluetely no idea how to force a QT theme since they removed the qtconfig app in qt5....

@fuchsmich
Copy link

fuchsmich commented Apr 13, 2017 via email

@oroulet
Copy link
Contributor Author

oroulet commented Apr 13, 2017

image

The big empty space appearde when you made the new sorting buttons not visible...

@fuchsmich
Copy link

fuchsmich commented Apr 13, 2017 via email

@oroulet
Copy link
Contributor Author

oroulet commented Apr 14, 2017

looks like css stylesheets are not supported in QML so we cannot reuse the sheets had...

@fuchsmich
Copy link

fuchsmich commented Apr 14, 2017 via email

@oroulet
Copy link
Contributor Author

oroulet commented Apr 18, 2017

for information if we use QApplication from QtGui and not QWidgets then we miss looking at standard systems icons (But this is probably a linux only functionality I guess)

@TRSx80
Copy link

TRSx80 commented Jun 23, 2017

I already made similar comment under #53, but I just wanted to re-state it here. I agree strongly with @oroulet comment of:

I agree that we should use system theming as much as possible.

FWIW, I am on KDE Plasma with Breeze Dark theme and everything looks very good to me. I know you guys are on different environments, so perhaps I can help the project by reporting what I am seeing in my environment. I don't know enough about coding (yet) but I do want to contribute what I can because I love the project and it meets my needs just about perfectly. :)

@oroulet
Copy link
Contributor Author

oroulet commented Jun 23, 2017 via email

@severoraz
Copy link

I am using gnome 3 (3.26) with the dark theme and qtodotxt2 did not adopt the dark colours.

@oroulet
Copy link
Contributor Author

oroulet commented Nov 11, 2017

@severoraz I have the same issue. It look like qt5 applcations do not get theme from gnome... While the doc says they should... something does not work....
And it looks like qt5 has no tool to set a theme by hand... any help is welcome on that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants