Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(static-cmp): Static resource matching optimization #112

Merged
merged 4 commits into from
Jul 7, 2022
Merged

perf(static-cmp): Static resource matching optimization #112

merged 4 commits into from
Jul 7, 2022

Conversation

PIGfaces
Copy link
Contributor

@PIGfaces PIGfaces commented Jul 1, 2022 •
edited
Loading

改动说明

主要修复 #106 和代码优化

  • 代码优化
    • 减少内存分配
    • 降低时间复杂度
    • 去掉阻塞 goroutinue
  • Bug 修复

PIGfaces
PIGfaces commented Jul 1, 2022
View reviewed changes
Copy link
Contributor Author

@PIGfaces PIGfaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 更新了 chromdp 依赖库，执行导航页使用了优化后的原方式
  • 去掉了无意义的阻塞 goroutine

@PIGfaces PIGfaces mentioned this pull request Jul 6, 2022
Closed
@Qianlitp
Copy link
Owner

Qianlitp commented Jul 6, 2022

为什么要删除隐身模式选项呢

@PIGfaces
Copy link
Contributor Author

PIGfaces commented Jul 7, 2022

为什么要删除隐身模式选项呢

在测试过程中发现创建了隐身模式上下文但其实并没有生效，在 chromedp 中也有人提出过对应的 ISSUE： chromedp/chromedp#997 (comment)

@Qianlitp Qianlitp merged commit 5bd29ce into Qianlitp:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PIGfaces @Qianlitp