Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Timestamp parameter from MessageCallback #3

Closed
zieckey opened this issue Mar 14, 2017 · 1 comment
Closed

Remove Timestamp parameter from MessageCallback #3

zieckey opened this issue Mar 14, 2017 · 1 comment
Labels
enhancement

Comments

@zieckey
Copy link
Collaborator

zieckey commented Mar 14, 2017 

typedef std::function<void(const TCPConnPtr&, Buffer*, Timestamp)> MessageCallback;

The MessageCallback has three parameters, the third one is a timestamp which is the data receiving time.
In most case, this parameter is not necessary.

So I suggest to remove it.

Any one has ideals?
@zieckey zieckey changed the title Remove Timestamp parameter from MessageCallback Remove Timestamp parameter from MessageCallback Mar 14, 2017
zieckey added a commit that referenced this issue Mar 14, 2017
@zieckey
Refactor : Remove Timestamp parameter from MessageCallback #3
b110a48
zieckey added a commit that referenced this issue Mar 15, 2017
@zieckey
Refactor : Remove Timestamp parameter from MessageCallback #3
ffea539
@zieckey
Copy link
Collaborator Author

zieckey commented Mar 15, 2017

We have refactored it.

@zieckey zieckey closed this as completed Mar 15, 2017
@liwei-ch liwei-ch mentioned this issue Mar 17, 2017
Closed
zieckey added a commit that referenced this issue Mar 17, 2017
@zieckey
Refactor : Remove Timestamp parameter from MessageCallback #3
dc7550f
zieckey added a commit that referenced this issue Mar 25, 2017
@zieckey
Refactor : Remove Timestamp parameter from MessageCallback #3
cce1c84
zieckey added a commit that referenced this issue Apr 27, 2017
@zieckey
Refactor : Remove Timestamp parameter from MessageCallback #3
d1a8d2c
@mdsf22 mdsf22 mentioned this issue May 12, 2017
Open
zieckey added a commit that referenced this issue May 20, 2017
@zieckey
Refactor : Remove Timestamp parameter from MessageCallback #3
8cca809
zieckey added a commit that referenced this issue May 20, 2017
@zieckey
Refactor : Remove Timestamp parameter from MessageCallback #3
35d9616
@bigtang5 bigtang5 mentioned this issue Jul 3, 2017
Open
@acyi acyi mentioned this issue Sep 4, 2017
Closed
@saahilcc saahilcc mentioned this issue Sep 25, 2017
Closed
@esinple esinple mentioned this issue Dec 11, 2017
Open
@Arielce Arielce mentioned this issue Aug 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zieckey