Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbering RFC 0011 #39

Merged
merged 1 commit into from
May 11, 2023
Merged

Numbering RFC 0011 #39

merged 1 commit into from
May 11, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Apr 27, 2023

The RFC titled Plan to rename Qiskit/qiskit-terra repo to Qiskit/qiskit is assigned number 0011.

@1ucian0 1ucian0 mentioned this pull request Apr 27, 2023
Closed
7 tasks
jakelishman
jakelishman reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be useful to associate the RFC number with the PR number that added it, so the discussion surrounding the PR and any historical changes to it are stored. In that case, we might want to assign this RFC number #31.

@1ucian0
Copy link
Member Author

1ucian0 commented Apr 27, 2023 •
edited
Loading

If I remember @mtreinish 's Readme interpretation, the idea is to number the rfcs after merge, in consecutive order. Maybe something to discuss?

@jakelishman
Copy link
Member

Looks like that was the initial intent, but also the initial intent is that merge was done by a merge strategy and not a squash strategy. Since we've not abided by that, I think maintaining a link to the PR history is probably a good idea, in the spirit of the original intent.

@1ucian0
Copy link
Member Author

1ucian0 commented Apr 29, 2023

I think maintaining a link to the PR history is probably a good idea, in the spirit of the original intent.

done in 8411ffb Thanks!

@1ucian0 1ucian0 mentioned this pull request Apr 29, 2023
Merged
@1ucian0 1ucian0 changed the title Numbering RFC0011 Numbering RFC 0011 Apr 29, 2023
@mtreinish mtreinish merged commit 278987f into Qiskit:master May 11, 2023
@1ucian0 1ucian0 added the repo organization Related to the organization of the repo, without changing the nature of any RFC label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman left review comments

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
repo organization Related to the organization of the repo, without changing the nature of any RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1ucian0 @jakelishman @mtreinish