Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused custom CSS files and Sphinx directives #268

Merged
merged 2 commits into from
May 12, 2023
Merged

Remove unused custom CSS files and Sphinx directives #268

merged 2 commits into from
May 12, 2023

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented May 11, 2023 •
edited
Loading

No one was using the custom directives galleryitem and customgalleryitem. After removing this, it's safe to remove sphinx-gallery because it's not used. That allows removing gallery.css, which is meant to override sphinx-gallery's default styling.

This also removes two CSS files:

  • custom.css: There is no .toggle element anymore
  • style.css: its 3 rules are holdovers from the Read The Docs theme

t-imamichi
t-imamichi previously approved these changes May 12, 2023
View reviewed changes
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4958842130

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.793%
Totals Coverage Status
Change from base Build 4929960311: 0.0%
Covered Lines: 645
Relevant Lines: 851
💛 - Coveralls

@woodsp-ibm woodsp-ibm added stable backport potential The bug might be minimal and/or import enough to be port to stable type: documentation Issues related to documentation automerge labels May 12, 2023
@mergify mergify bot merged commit 2e14a99 into qiskit-community:main May 12, 2023
mergify bot pushed a commit that referenced this pull request May 12, 2023
@Eric-Arellano @mergify
Remove unused custom CSS files and Sphinx directives (#268)
7e18f39 
* Remove unused custom CSS files and Sphinx directives

* Remove bad import

(cherry picked from commit 2e14a99)
@mergify mergify bot mentioned this pull request May 12, 2023
Merged
@Eric-Arellano Eric-Arellano deleted the rm-gallery branch May 12, 2023 14:05
mergify bot added a commit that referenced this pull request May 12, 2023
@mergify @Eric-Arellano
Remove unused custom CSS files and Sphinx directives (#268) (#269)
0cd5a39 
* Remove unused custom CSS files and Sphinx directives

* Remove bad import

(cherry picked from commit 2e14a99)

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@t-imamichi t-imamichi t-imamichi left review comments

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

Assignees
No one assigned
Labels
automerge stable backport potential The bug might be minimal and/or import enough to be port to stable type: documentation Issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eric-Arellano @coveralls @t-imamichi @woodsp-ibm