Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

Misleading indentation of some TOC entries #67

Closed
diego-plan9 opened this issue Feb 6, 2019 · 1 comment · Fixed by #145
Closed

Misleading indentation of some TOC entries #67

diego-plan9 opened this issue Feb 6, 2019 · 1 comment · Fixed by #145
Assignees
Labels
bug Something isn't working documentation Something is not clear or error in description theme Issues related to the documentation theme

Comments

@diego-plan9
Copy link
Member

diego-plan9 commented Feb 6, 2019

Some items/levels in the TOC are shown with the wrong indentation, hindering readability - for example:

toc

In the screenshot, the Terra organization entry is visually at the same level as Overview, but the real hierarchy is:

Qiskit Terra
    Overview
        Terra Organization
    The Quantum Circuit
    ...

Pinging @Borjagodoy - can you double check the relevant parts of the theme for the TOC? Please note that there might be other oddities potentially related, such as the indentation for an "entry that has subentries" vs the intentation for an "entry that has no subentries".

Also, it seems the original theme already had the collapsing/expanding functionality baked in by default (on the sample site, with some circles around the arrows and no extra changes) - can you evaluate if we can reuse it directly, instead of tuning the html and CSS?

@diego-plan9 diego-plan9 added bug Something isn't working documentation Something is not clear or error in description labels Feb 6, 2019
@diego-plan9
Copy link
Member Author

Following up on the last bit of the comment, currently there are two <div class="globaltoc"> entries, which might be related. Since each one takes up ~40kb (and we end up producing ~400 files), can we also look into removing this duplicity, as it is also causing some minor issues in non-javascript enabled browsers?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Something is not clear or error in description theme Issues related to the documentation theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants