Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update circuit construction benchmarks #11924

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Update circuit construction benchmarks #11924

merged 1 commit into from
Mar 1, 2024

Conversation

mtreinish
Copy link
Member

Summary

The circuit construction benchmarks had all bit rotted a fair amount and were using syntax and functionality that no longer exists. This commit updates the benchmarks to work with current qiskit. Longer term we should add a CI job to ensure all the benchmarks work.

Details and comments

@mtreinish
Update circuit construction benchmarks
1dec2d3 
The circuit construction benchmarks had all bit rotted a fair amount and
were using syntax and functionality that no longer exists. This commit
updates the benchmarks to work with current qiskit. Longer term we
should add a CI job to ensure all the benchmarks work.
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Feb 29, 2024
@mtreinish mtreinish requested a review from a team as a code owner February 29, 2024 23:50
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8104195402

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 89.312%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 91.94%
Totals Coverage Status
Change from base Build 8102006837: 0.01%
Covered Lines: 59126
Relevant Lines: 66202
💛 - Coveralls

kevinhartman
kevinhartman approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Agreed, we ought to add some validation to CI soon.

@kevinhartman kevinhartman added this pull request to the merge queue Mar 1, 2024
Merged via the queue into Qiskit:main with commit bba28b8 Mar 1, 2024
12 checks passed
IsmaelCesar pushed a commit to comp-quantica/qiskit-terra that referenced this pull request Mar 13, 2024
@mtreinish @IsmaelCesar
Update circuit construction benchmarks (Qiskit#11924)
3abd006 
The circuit construction benchmarks had all bit rotted a fair amount and
were using syntax and functionality that no longer exists. This commit
updates the benchmarks to work with current qiskit. Longer term we
should add a CI job to ensure all the benchmarks work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinhartman kevinhartman kevinhartman approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtreinish @qiskit-bot @coveralls @kevinhartman