-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pyo3 and rust numpy version to 0.19.0 #887
Conversation
Pyo3 0.19.0 and rust-numpy 0.19.0 were just released. This commit updates the version used in rustworkx to these latest releases. At the same time this updates usage of text signature for classes that was deprecated in 0.19.0 release. While not fatal for normal builds this would have failed clippy in CI because we treat warnings as errors.
Pull Request Test Coverage Report for Build 5144317507
💛 - Coveralls |
Oh wow my stubs test is failing. Probably if you put |
I ran it locally and I can confirm that changing https://github.com/Qiskit/rustworkx/blob/main/rustworkx/iterators.pyi#L71 to |
It must be caused by an upstream change in rust-numpy (or something around that). I'll edit the stub file, as I think it'd be good to try and get this in for 0.13.0 which besides #823 I think is ready. |
Pyo3 0.19.0 and rust-numpy 0.19.0 were just released. This commit updates the version used in rustworkx to these latest releases. At the same time this updates usage of text signature for classes that was deprecated in 0.19.0 release. While not fatal for normal builds this would have failed clippy in CI because we treat warnings as errors.