Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyo3 and rust numpy version to 0.19.0 #887

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

mtreinish
Copy link
Member

Pyo3 0.19.0 and rust-numpy 0.19.0 were just released. This commit updates the version used in rustworkx to these latest releases. At the same time this updates usage of text signature for classes that was deprecated in 0.19.0 release. While not fatal for normal builds this would have failed clippy in CI because we treat warnings as errors.

Pyo3 0.19.0 and rust-numpy 0.19.0 were just released. This commit
updates the version used in rustworkx to these latest releases. At the
same time this updates usage of text signature for classes that was
deprecated in 0.19.0 release. While not fatal for normal builds this
would have failed clippy in CI because we treat warnings as errors.
@mtreinish mtreinish added this to the 0.13.0 milestone May 31, 2023
@coveralls
Copy link

coveralls commented May 31, 2023

Pull Request Test Coverage Report for Build 5144317507

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 96.463%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 1 98.54%
src/traversal/mod.rs 2 96.23%
src/shortest_path/mod.rs 5 98.4%
src/iterators.rs 7 86.14%
Totals Coverage Status
Change from base Build 5143940500: -0.05%
Covered Lines: 15082
Relevant Lines: 15635

💛 - Coveralls

@IvanIsCoding
Copy link
Collaborator

IvanIsCoding commented May 31, 2023

Oh wow my stubs test is failing. Probably if you put Optional in iterators.pyi for the array method it will fix it

@mtreinish mtreinish removed this from the 0.13.0 milestone May 31, 2023
@IvanIsCoding
Copy link
Collaborator

I ran it locally and I can confirm that changing https://github.com/Qiskit/rustworkx/blob/main/rustworkx/iterators.pyi#L71 to def __array__(self, _dt: Optional[np.dtype] = ...) -> np.ndarray: ... and adding the respective import solves the test problem

@mtreinish
Copy link
Member Author

mtreinish commented Jun 1, 2023

It must be caused by an upstream change in rust-numpy (or something around that). I'll edit the stub file, as I think it'd be good to try and get this in for 0.13.0 which besides #823 I think is ready.

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Jun 1, 2023
@IvanIsCoding IvanIsCoding merged commit 6982d59 into Qiskit:main Jun 1, 2023
@mtreinish mtreinish deleted the bump-pyo3-19 branch June 1, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants