Wallet modules #353
Closed
Wallet modules #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lochjin
requested changes
Mar 21, 2023
| @@ -258,17 +258,15 @@ func (this *QitmeerRobot) SubmitWork() { | |||
| } | |||
| } | |||
| this.SubmitLock.Unlock() | |||
| if err != ErrLimitWork { // limit wait block connect | |||
There was a problem hiding this comment.
Is there no need to add a frequency limit here?
dindinw
requested changes
Mar 22, 2023
| return nil, err | ||
| } | ||
| return mtxHex, nil | ||
| return api.txManager.CreateRawTransactionV2(inputs, aa, lockTime) |
There was a problem hiding this comment.
I don't get the idea why we has to move the api logic into the txManager ?
node/full.go
Outdated
| @@ -146,6 +149,16 @@ func (qm *QitmeerFull) RegisterAccountService(cfg *config.Config) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (qm *QitmeerFull) RegisterWalletService(cfg *config.Config, conf node.Config, _am *acct.AccountManager, _tm *tx.TxManager) error { | |||
There was a problem hiding this comment.
should not introduce the depend on github.com/ethereum/go-ethereum/node here by using the node.Config
you might have to refactor the wallet.New API and it may be better to use the go-ethereum internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.