Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to retrieve existing stop losses #39

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

fernandobrito
Copy link
Contributor

Hi! I'm in the process of automating the update of my stop losses on Avanza and the first step in my automation is that I need to check my existing stop losses. Is that something you want to have merged here as well? The next step (another PR later this month) is another endpoint to actually be able to create new stops and delete existing ones.

Thanks for the lib!

Example of a real response using the code from this PR:
image

@warna720
Copy link
Contributor

warna720 commented Oct 5, 2021

Does the endpoint accept any parameters/filters?
If so, it would be nice to include does as well or at least document them.
Besides that, looks good.

@fernandobrito
Copy link
Contributor Author

Hi @warna720, sorry for the delay!

Thanks for taking a look. From the UI I can't see any filters or interactive elements that would be represented as parameters in this endpoint.

image

Also from the Android app I can't find anything, so to the best of my knowledge, there are no possible parameters.

I've been using this in my pet project for a month and it has been working great.

@warna720
Copy link
Contributor

LGTM then.
@Qluxzz have the last word though

@Qluxzz
Copy link
Owner

Qluxzz commented Nov 14, 2021

Thank you @warna720 for the code review, and thank you @fernandobrito for contributing!

@Qluxzz Qluxzz merged commit 3f069d9 into Qluxzz:master Nov 14, 2021
@fernandobrito
Copy link
Contributor Author

Amazing, thank you @Qluxzz for the library and the time maintaining it. 👏 . Wish you lots of profits in the market!

@Robinhiio
Copy link

@fernandobrito
Hi! Did you ever succeeded/continued with functionality for creating new stop losses ?

@fernandobrito
Copy link
Contributor Author

Hi @Robinhiio. Unfortunately not. I ended up moving away from Avanza to Degiro (when they were still opening new ISK accounts, which they are not doing anymore today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants