Fixes for issue #69 and issue #91 plus minor networking #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidying up Network/Peer/Controller/Synchronizer. Don't consider peers for synchronization that don't yet have ping info. Add defensive synchronized wrapper when broadcasting to peers. When shutting down, stop the connection acceptor and connection creator BEFORE closing connected peers. This stops new [dangling] peers from being created AFTER existing have been closed. Improve exception handling in Peer. Improve logging in Synchronizer. When synchronizing from a peer that's on a fork, restrict the number of blocks to receive in one go from that peer.
In Pinger's run() thread, wrap calls to Peer.onPingSuccess and Peer.onPingFailure in a new thread. This is to avoid mapdb ClosedByInterruptException issue caused by calling pinger.interrupt(), which then causes onPingSuccess to fail when it (eventually) tries a mapdb call.
Also slightly tidy up similar fix in Pinger (issue #91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.