Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exosys daemon #1

Merged
merged 16 commits into from
Aug 5, 2022
Merged

Exosys daemon #1

merged 16 commits into from
Aug 5, 2022

Conversation

Slesarew
Copy link
Contributor

make exosys track events and print them.

soon (days) parser crate upstream would start outputting typed objects

}
}

#[tokio::main]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote from https://docs.rs/tokio/latest/tokio/attr.main.html:

Note: This macro can be used on any function and not just the main function. Using it on a non-main function makes the function behave as if it was synchronous by starting a new runtime each time it is called. If the function is called often, it is preferable to create the runtime using the runtime builder so the runtime can be reused across calls.

Would not it be simpler to put it once on async fn main and .await calling these functions from there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I've just quickly slapped together chunks of other projects to get the result; I mean to run 2 or 3 threads there concurrently later. It's ugly everywhere at the moment.

@Slesarew Slesarew marked this pull request as ready for review August 2, 2022 08:04
@Slesarew
Copy link
Contributor Author

Slesarew commented Aug 2, 2022

Let's merge it as discussed yesterday?

@wigy-opensource-developer
Copy link
Member

wigy-opensource-developer commented Aug 3, 2022

@Slesarew How comfortable would you be to just create your own forked crates from parity-signer? Vera seemed to do a great job on these SCALE parsers, maybe you could publish it for the whole ecosystem to gain from them. Also, can we get rid of the desub dependency from here?

@Slesarew
Copy link
Contributor Author

Slesarew commented Aug 5, 2022

@Slesarew How comfortable would you be to just create your own forked crates from parity-signer? Vera seemed to do a great job on these SCALE parsers, maybe you could publish it for the whole ecosystem to gain from them. Also, can we get rid of the desub dependency from here?

I'm doing just that, rebranding and forkng (see fork and Alzymologist org). It will take some time though since i need to do everything legally and nicely. Any ideas for new brand name? We can push it to f-droid then finally.

@Slesarew Slesarew merged commit 2c50036 into Qrucial:main Aug 5, 2022
@Slesarew Slesarew deleted the as-exosys branch September 2, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants