-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task implementation. #64
Conversation
|
Build is failing because of the dependencies on https://github.com/QuEra-QCS/QCS-API-client we should probably think about importing this as a git submodule until we merge the implementation into Bloqade. |
@Roger-luo I think having an intermediate object before the |
anneal_time=10, | ||
rabi_amplitude_max=15, | ||
) | ||
.program.mock(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should stick to the original interface where the output of Emit
can directly changed with a backend and then further submit things, but let's do that separately and I don't think this is a blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this actually makes sense there are some methods that need to be implemented beyond submit. e.g. a validation method for a task that is useful to do before submission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's roughly there, but definitely needs further polish, let's keep working on small comments in separate PRs.
* adding visitor base class. * adding Lattice base to AstType * updating visitor classes adding base visitor class for waveforms * schema visitor code gen * assignment scan. * wrap `map` in `list` to loop over iterator. * fixing with ruff * refactor Emit to emit Program, renaming fields. * mock task is able to be saved and reloaded. * removing reference to __lattice__ * braket submission backend. * running ruff/black * fixing test. * adding quera-qcs-client dependency. * update lock * adding quera implementation * addin quera-qcs-client as submodule * updating workflows to checkout submodules * removing checkout submodules in github actions. * removing submodule adding api code * updating path to config * removing init. * code updates from review. * adding json loader. * adding future loader * adding dependency aws-request-auth for internal API authenticaiton.
The goal here should be to allow the user to serialize the various task objects so that they can be saved and accessed later without worrying about which backend is being used.