Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task implementation. #64

Merged
merged 29 commits into from
May 13, 2023
Merged

Task implementation. #64

merged 29 commits into from
May 13, 2023

Conversation

weinbe58
Copy link
Member

The goal here should be to allow the user to serialize the various task objects so that they can be saved and accessed later without worrying about which backend is being used.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023

PR Preview Action c04bc09
🚀 Deployed preview to https://Happy-Diode.github.io/bloqade-python/pr-preview/pr-64/
on branch gh-pages at 2023-05-13 13:56 UTC

@weinbe58 weinbe58 linked an issue May 12, 2023 that may be closed by this pull request
@weinbe58
Copy link
Member Author

weinbe58 commented May 12, 2023

Build is failing because of the dependencies on https://github.com/QuEra-QCS/QCS-API-client

we should probably think about importing this as a git submodule until we merge the implementation into Bloqade.

src/bloqade/builder/start.py Outdated Show resolved Hide resolved
src/bloqade/submission/config/dev_quera_api.json Outdated Show resolved Hide resolved
src/bloqade/task.py Outdated Show resolved Hide resolved
src/bloqade/task.py Outdated Show resolved Hide resolved
tests/_test_mock_submit.py Outdated Show resolved Hide resolved
tests/_test_mock_submit.py Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
src/bloqade/task.py Outdated Show resolved Hide resolved
@weinbe58
Copy link
Member Author

@Roger-luo I think having an intermediate object before the TaskFuture objects is unnecessary, so I removed them.

@weinbe58 weinbe58 requested a review from Roger-luo May 13, 2023 14:03
anneal_time=10,
rabi_amplitude_max=15,
)
.program.mock(10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stick to the original interface where the output of Emit can directly changed with a backend and then further submit things, but let's do that separately and I don't think this is a blocker

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this actually makes sense there are some methods that need to be implemented beyond submit. e.g. a validation method for a task that is useful to do before submission.

Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's roughly there, but definitely needs further polish, let's keep working on small comments in separate PRs.

@Roger-luo Roger-luo merged commit 47cdf80 into main May 13, 2023
@Roger-luo Roger-luo deleted the task-impl branch May 13, 2023 22:52
@weinbe58 weinbe58 linked an issue May 14, 2023 that may be closed by this pull request
kaihsin pushed a commit that referenced this pull request Sep 1, 2023
* adding visitor base class.

* adding Lattice base to AstType

* updating visitor classes adding base visitor class for waveforms

* schema visitor code gen

* assignment scan.

* wrap `map` in `list` to loop over iterator.

* fixing with ruff

* refactor Emit to emit Program, renaming fields.

* mock task is able to be saved and reloaded.

* removing reference to __lattice__

* braket submission backend.

* running ruff/black

* fixing test.

* adding quera-qcs-client dependency.

* update lock

* adding quera implementation

* addin quera-qcs-client as submodule

* updating workflows to checkout submodules

* removing checkout submodules in github actions.

* removing submodule adding api code

* updating path to config

* removing init.

* code updates from review.

* adding json loader.

* adding future loader

* adding dependency aws-request-auth for internal API authenticaiton.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open source QCS-API-client along with bloqade-python Design Task backend
2 participants