Tseitin Encoding #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be great to get your input on this, as I'm still trying to adapt to the style you've used. Took me a while to figure out what you were doing here... @st.composite
def NNF(draw):
return draw(st.recursive(variables(), internal))...but it's some awesome stuff! As I was writing the test case, I found myself needing a "forgetting" mechanism (cf. #7 ). Let me know if it happens to be somewhere there under a different name. |
blyxxyz
requested changes
Jul 24, 2020
blyxxyz
reviewed
Jul 30, 2020
|
@blyxxyz Good to merge with this one? Thanks for bearing with me! |
|
Ouch... Lgtm. Merge away if you're fine with it. Will make kissat optional tonight on the other branch. |
|
Merged to have a cleaner PR on the kissat integration. Feel free to re-open if anything remains, but I think we're pretty well set here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5