Use nodes' app names for instruction logging #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvdvecht
reviewed
Jan 26, 2023
platelminto
force-pushed
the
feature/QNEBE-657/app-name-instruction-logs
branch
from
372310b
to
010da40
Compare
bvdvecht
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We revert to the logging behaviour seen in v0.5.5, where output logs for specific nodes' instructions should use the app name in the filename.
Example, for an app (role) named 'receiver' located in 'delft':
< v0.5.5->receiver_instrs.yamlv0.6.0 - v0.12.2->delft_instrs.yamlv0.13.0(this PR) ->receiver_instrs.yamlIt was (likely) inadvertently changed to the node's location, rather than the app name, in v0.6.0. This mirrors the naming format of the
{app_name}_class_comm.yamlfiles in the same logging directory.This solution does what the old code used to do - simply re-write the files at the end of the simulation.