Feat: Brokerage Cross Position Order #8051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Romazes
force-pushed
the
feature-brokerage-crossing-helper
branch
from
5823b63
to
492fce3
Compare
Romazes
force-pushed
the
feature-brokerage-crossing-helper
branch
from
42df918
to
62a4756
Compare
feat: helper methods to CrossPosition
rename: TryCrossPositionOrder -> TryCrossZeroPositionOrder feat: handle event of CrossZeroOrder feat: new prop in CrossZeroOrderRequest test:feat: write working test imitate of CrossZeroOrdering and assert different params
feat: helper method for CrossZeroCollection
refactor: CrossZeroOrders tests
… place feat: message property in CrossZeroOrderResponse refactor: CrossBrokerageTest a little bit
refactor: change action scenario for Filled FirstPart of CrossZeroOrder
…sZero order completely fix: crossZeroOrder test put orderStatus internally
Romazes
force-pushed
the
feature-brokerage-crossing-helper
branch
from
62a4756
to
82380fd
Compare
Martin-Molinero
approved these changes
Jun 24, 2024
remove: extra validation of variable
This was referenced Jun 26, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new feature that supports the creation of cross position orders in our brokerage module. The main components of this feature include utility methods and helper functions that encapsulate the brokerage-specific logic required for cross positions. This enhancement aims to streamline the process and improve the efficiency of handling cross position orders.
Related Issue
N/A
Motivation and Context
Cross position orders are essential in scenarios where clients have multiple positions and want to execute a single order across them. This feature addresses the need for a seamless mechanism to facilitate such orders within our brokerage platform. By automating the cross position order process, we enhance user experience and increase operational efficiency.
Changes Included
Requires Documentation Change
N/A
How Has This Been Tested?
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>