Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QuantEcon.next_k_array! in support_enumeration #81

Merged
merged 1 commit into from
May 28, 2018
Merged

Use QuantEcon.next_k_array! in support_enumeration #81

merged 1 commit into from
May 28, 2018

Conversation

monsij
Copy link
Contributor

@monsij monsij commented May 22, 2018

Closes Issue #70

All the changes have been made similar to QuantEcon/QuantEcon.py@a215f1f

@monsij
Copy link
Contributor Author

monsij commented May 22, 2018

New changes made! @oyamad

@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #81 into master will decrease coverage by 3.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   96.36%   92.52%   -3.85%     
==========================================
  Files           6        6              
  Lines         468      468              
==========================================
- Hits          451      433      -18     
- Misses         17       35      +18
Impacted Files Coverage Δ
src/support_enumeration.jl 78.16% <100%> (-20.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506ea7d...b5d150c. Read the comment docs.

@sglyon
Copy link
Member

sglyon commented May 28, 2018

Thank you!

@sglyon sglyon merged commit b921342 into QuantEcon:master May 28, 2018
@sglyon
Copy link
Member

sglyon commented May 28, 2018

Hi @monsij thanks for the contribution.

I noticed that we still have the routine _next_k_array! defined in src/support_enumeration.jl. Is this still needed? If not, can we delete it also?

Thanks

@monsij
Copy link
Contributor Author

monsij commented May 28, 2018

@sglyon My pleasure!

@oyamad
Copy link
Member

oyamad commented May 29, 2018

@monsij Thanks for the PR.

The Python version QuantEcon/QuantEcon.py@a215f1f consists of three changes:

  1. import next_k_array;
  2. replace the string _next_k_array by next_k_array;
  3. delete the function definitions of _next_k_combination and _next_k_array.

This PR does only 2.

@monsij Will you be willing to set up one more pull request to make the other changes?

  1. Add

    import QuantEcon: next_k_array!

    (This seems not to be necessary, but I believe it better to be explicit.)

&

  1. Delete the definitions of _next_k_combination and _next_k_array!.

Thanks!

@sglyon
Copy link
Member

sglyon commented May 29, 2018

Thank you @oyamad -- sorry for the pre-mature merge on my part

@monsij
Copy link
Contributor Author

monsij commented May 29, 2018

@oyamad @sglyon I will be making these changes too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants